Review Request: Make KFilterProxySearchLine look more like KDEs searchlines

[Tom Albers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1622/#review2390
-----------------------------------------------------------

Ship it!


Looks good, one comment. If you tested it, feel free to commit.


trunk/KDE/kdelibs/kdeui/itemviews/kfilterproxysearchline.cpp
<http://reviewboard.kde.org/r/1622/#comment1702>

    Qlabel include can be removed now?


- Tom


On 2009-09-17 09:41:42, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1622/
> -----------------------------------------------------------
> 
> (Updated 2009-09-17 09:41:42)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Imho using KLineEdit::setClickMessage is nicer and more common into KDE instead of an additional QLabel. I left the inheritance from QWidget as is since future additions would be made more easily but the widget could directly inherit from KLineEdit now.
> 
> Suggestions/insults are welcome :)
> 
> Cheers
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/itemviews/kfilterproxysearchline.cpp 1023670 
> 
> Diff: http://reviewboard.kde.org/r/1622/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>