Review Request: Make KFilterProxySearchLine look more like KDEs searchlines

Alessandro Diaferia alediaferia at gmail.com
Thu Sep 17 10:41:43 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1622/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Imho using KLineEdit::setClickMessage is nicer and more common into KDE instead of an additional QLabel. I left the inheritance from QWidget as is since future additions would be made more easily but the widget could directly inherit from KLineEdit now.

Suggestions/insults are welcome :)

Cheers


Diffs
-----

  trunk/KDE/kdelibs/kdeui/itemviews/kfilterproxysearchline.cpp 1023670 

Diff: http://reviewboard.kde.org/r/1622/diff


Testing
-------


Thanks,

Alessandro





More information about the kde-core-devel mailing list