KICONLOADER_CHECKS still necessary?

[Boudewijn Rempt]

I was playing with Lennart Poetterings new mutrace tool and we discovered that 
the tool was hanging on the exit of every kde application. That has been 
fixed, but I was curious why. It turns out that mutrace hung on kbacktrace, 
which is called in this code:

KIconLoader::~KIconLoader()
{
#ifdef KICONLOADER_CHECKS
    for( QList< KIconLoaderDebug >::Iterator it = kiconloaders->begin();
         it != kiconloaders->end();
         ++it )
        {
        if( (*it).loader == this )
            {
            (*it).valid = false;
            (*it).delete_bt = kBacktrace();
            break;
            }
        }
#endif
      delete d;
}

I'm wondering whether this define is still needed. According to the comments, 
was created to detect bugs like #68528 -- but isn't a unittest more 
appropriate than executing all this overhead for everyone who closes a KDE 
application?

-- 
Boudewijn Rempt | http://www.valdyas.org