Review Request: Jpeg thumbnailer honouring jpeg rotation info

Jacopo De Simoi wilderkde at
Tue Sep 15 17:43:06 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-09-15 16:43:05.988185)

Review request for kdelibs.


Take care of libexiv exceptions by just ignoring them. I believe that there is no point in doing anything fancier in a kioslave. 
The implementation uses catch (...); if you think that it is not good enough I can copy the ifdef dance from gwenview. 


This patch makes the jpeg thumbnailer honor jpeg rotation infos stored in exif metadata. 
The method is quite simple, although I don't like ifdefs, this time they seem to me to be necessary.
It's my first nontrivial CMake modification; please check that I did not do something stupid there.
Also, the orientationMatrix method could be ifdeffed if you feel it is necessary; I just didn't want to add another ifdef.

I am not sure if this is a good solution performance-wise; please comment on that if you have better ideas.

Diffs (updated)

  trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1023383 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/jpegcreator.h 1023383 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/jpegcreator.cpp 1023383 



Works good with a *clean* .thumbnails directory. Cached thumbnails are indeed a problem; not sure how to solve this issue yet.


Dolphin showing correctly rotated jpegs



More information about the kde-core-devel mailing list