Review Request: Add thubnail support for Microsoft Windows executables and images

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1533/#review2353
-----------------------------------------------------------


Converting a .ico to a .png can be done with Qt's .ico support, no?
But since extracting icons from an .exe needs these icotools anyway, this wouldn't allow dropping the dependency, it would just make the ico-to-png conversion faster, I guess.

- David


On 2009-09-08 13:42:30, Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1533/
> -----------------------------------------------------------
> 
> (Updated 2009-09-08 13:42:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add thubnail support for Microsoft Windows executables (.exe, .dll, .ocx, ...) and images (.ico, .cur, ...) in konqueror/dolphin.
> 
> It use external applications icoutils from http://www.nongnu.org/icoutils/
> 
> 
> This addresses bug 185348.
>     https://bugs.kde.org/show_bug.cgi?id=185348
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagethumbnail.desktop PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.h PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.cpp PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.h PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.cpp PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexethumbnail.desktop PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp PRE-CREATION 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1021172 
>   trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1533/diff
> 
> 
> Testing
> -------
> 
> With wine it works fine for me.
> 
> 
> Thanks,
> 
> Pali
> 
>