Review Request: Add thubnail support for Microsoft Windows executables and images

Pali Rohár pali.rohar at gmail.com
Tue Sep 8 14:42:31 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1533/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This patch add thubnail support for Microsoft Windows executables (.exe, .dll, .ocx, ...) and images (.ico, .cur, ...) in konqueror/dolphin.

It use external applications icoutils from http://www.nongnu.org/icoutils/


This addresses bug 185348.
    https://bugs.kde.org/show_bug.cgi?id=185348


Diffs
-----

  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagethumbnail.desktop PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.h PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.cpp PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.h PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.cpp PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexethumbnail.desktop PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp PRE-CREATION 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1021172 
  trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1533/diff


Testing
-------

With wine it works fine for me.


Thanks,

Pali





More information about the kde-core-devel mailing list