Review Request: Add accessors for Solid Predicate internals previously only exposed in ctor's

Ben Cooksley sourtooth at gmail.com
Thu Sep 3 07:57:28 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1491/
-----------------------------------------------------------

(Updated 2009-09-03 06:57:27.794013)


Review request for kdelibs and Kevin Ottens.


Changes
-------

Update changes as per Kevin's comments.


Summary
-------

Adds accessors for internal objects previously exposed in ctor's, and the OperatorType enum.
This allows applications such as the Device Actions KCM to share the same parsing implementation as libsolid and prevents code duplication, etc.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/solid/solid/predicate.h 1018534 
  /trunk/KDE/kdelibs/solid/solid/predicate.cpp 1018534 

Diff: http://reviewboard.kde.org/r/1491/diff


Testing
-------

Compiles.


Thanks,

Ben





More information about the kde-core-devel mailing list