Review Request: KIO: KDesktopFileActions: Fix (un)mounting offers in Solid

Aaron Seigo aseigo at kde.org
Wed Oct 28 22:10:48 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2001/#review2845
-----------------------------------------------------------

Ship it!


looks good, and similar to what we're doing in the device notifier.

- Aaron


On 2009-10-28 13:12:12, Rafa? Mi?ecki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2001/
> -----------------------------------------------------------
> 
> (Updated 2009-10-28 13:12:12)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Current condition doesn't work properly. For example it offers unmounting root partition and does not offer ejecting unmounted CD.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/kdesktopfileactions.cpp 1041546 
> 
> Diff: http://reviewboard.kde.org/r/2001/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rafa?
> 
>





More information about the kde-core-devel mailing list