Review Request: KFilePlacesModel: Separating the interface from the implementation...

[nf2.email at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1951/
-----------------------------------------------------------

(Updated 2009-10-25 23:21:48.764351)


Review request for kdelibs, Peter Penz, Kevin Ottens, and David Faure.


Changes
-------

* Tries to load an alternate KFilePlacesModelImpl, hosted in the kio-giobridge package:
http://websvn.kde.org/trunk/playground/ioslaves/kio-giobridge/kfileplacesmodel-plugin/

It tries to mimic the places-structure in Gtk-Filechoosers/Nautilus, is based on GVolumeMonitor, and reads ~/.gtk-bookmarks (see the screenshot).

Thanks for the review David, this patch depends on http://reviewboard.kde.org/r/1880/ , that's how the additional roles slipped in.

Kevin, what shall I do. ;-) Of course I respect that you don't want this, and it's your code I'm trying to hijack. But I just wanted to finish this little demo. It's hard to stop right in front of the target line.


Summary
-------

This is a preview patch of how I would like to allow plugging different KFilePlacesModel implementations:

* There is a new interface class "KFilePlacesModelImpl".
* KFilePlacesModel::Private is replaced by a pointer to an instance of "KFilePlacesModelImpl".
* The code from kfileplacesmodel.cpp is moved to the new KFilePlacesModelKde class, which implements this interface.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kfileplacesmodel.h 1030975 
  /trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp 1029742 
  /trunk/KDE/kdelibs/kfile/kfileplacesmodel_kde.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kfile/kfileplacesmodel_kde_p.h PRE-CREATION 
  /trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.h PRE-CREATION 
  /trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1951/diff


Testing
-------


Screenshots
-----------

screenshot filechoosers and filemanagers
  http://reviewboard.kde.org/r/1951/s/238/


Thanks,

nf2