Review Request: Make KDirWatch inotify threaded.

[ahartmetz at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1963/#review2795
-----------------------------------------------------------


In some accessor methods the d-pointer check comes after using the mutex somewhere behind the d-pointer. That is very likely not correct.

- maelcum


On 2009-10-24 13:45:55, Sebastian Sauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1963/
> -----------------------------------------------------------
> 
> (Updated 2009-10-24 13:45:55)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Problem;
> Under heavy hd load (e.g. compiling KDE) KDirWatch may freeze for fractions of seconds or even longer.
> 
> Solution;
> Do the same QFileSystemWatcher (qt/src/corelib/io/qfilesystemwatcher_inotify.cpp) does and make the QSocketNotifier+inotifyEventReceived logic threaded.
> 
> Warning;
> This *needs* review.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/kdirwatch_p.h 1038809 
>   /trunk/KDE/kdelibs/kio/kio/kdirwatch.cpp 1038809 
> 
> Diff: http://reviewboard.kde.org/r/1963/diff
> 
> 
> Testing
> -------
> 
> kdelibs/kio/tests/kdirwatch, kdelibs/kio/tests/kdirwatch_gui
> 
> 
> Thanks,
> 
> Sebastian
> 
>