Review Request: Make KDirWatch inotify threaded.
Sebastian Sauer
mail at dipe.org
Sat Oct 24 14:45:55 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1963/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
Problem;
Under heavy hd load (e.g. compiling KDE) KDirWatch may freeze for fractions of seconds or even longer.
Solution;
Do the same QFileSystemWatcher (qt/src/corelib/io/qfilesystemwatcher_inotify.cpp) does and make the QSocketNotifier+inotifyEventReceived logic threaded.
Warning;
This *needs* review.
Diffs
-----
/trunk/KDE/kdelibs/kio/kio/kdirwatch_p.h 1038809
/trunk/KDE/kdelibs/kio/kio/kdirwatch.cpp 1038809
Diff: http://reviewboard.kde.org/r/1963/diff
Testing
-------
kdelibs/kio/tests/kdirwatch, kdelibs/kio/tests/kdirwatch_gui
Thanks,
Sebastian
More information about the kde-core-devel
mailing list