Review Request: KFilePlacesModel: Separating the interface from the implementation...

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1951/#review2788
-----------------------------------------------------------


Sorry, but no. We don't need this, consider this one rejected (it's not like we didn't discuss this before).

- Kevin


On 2009-10-23 13:32:24, nf2 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1951/
> -----------------------------------------------------------
> 
> (Updated 2009-10-23 13:32:24)
> 
> 
> Review request for kdelibs, Peter Penz, Kevin Ottens, and David Faure.
> 
> 
> Summary
> -------
> 
> This is a preview patch of how I would like to allow plugging different KFilePlacesModel implementations:
> 
> * There is a new interface class "KFilePlacesModelImpl".
> * KFilePlacesModel::Private is replaced by a pointer to an instance of "KFilePlacesModelImpl".
> * The code from kfileplacesmodel.cpp is moved to the new KFilePlacesModelKde class, which implements this interface.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel.h 1039204 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp 1039204 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel_kde.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel_kde_p.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1951/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nf2
> 
>