Review Request: KFilePlacesModel: Separating the interface from the implementation...

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1951/#review2787
-----------------------------------------------------------



/trunk/KDE/kdelibs/kfile/kfileplacesmodel.h
<http://reviewboard.kde.org/r/1951/#comment2148>

    These additional roles seem unrelated to the splitting out of the implementation, I suggest removing them from this patch.



/trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp
<http://reviewboard.kde.org/r/1951/#comment2149>

    One ";" too many :)



/trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.h
<http://reviewboard.kde.org/r/1951/#comment2147>

    If the class is exported, it has to be treated as BC. Since it derives from QObject, adding new "virtuals" won't be difficult, we'll just define slots and use QMetaObject::invokeMethod.


- David


On 2009-10-23 13:32:24, nf2 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1951/
> -----------------------------------------------------------
> 
> (Updated 2009-10-23 13:32:24)
> 
> 
> Review request for kdelibs, Peter Penz, Kevin Ottens, and David Faure.
> 
> 
> Summary
> -------
> 
> This is a preview patch of how I would like to allow plugging different KFilePlacesModel implementations:
> 
> * There is a new interface class "KFilePlacesModelImpl".
> * KFilePlacesModel::Private is replaced by a pointer to an instance of "KFilePlacesModelImpl".
> * The code from kfileplacesmodel.cpp is moved to the new KFilePlacesModelKde class, which implements this interface.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel.h 1039204 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp 1039204 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel_kde.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodel_kde_p.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kfile/kfileplacesmodelimpl.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1951/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nf2
> 
>