Review Request: paintbuffer.h:128: warning: suggest parentheses around && within ||

Guy Maurel guy-kde at maurel.de
Wed Oct 21 21:05:37 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1927/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/khtml/misc/paintbuffer.h:128: warning: suggest parentheses around && within ||

at
void transfer( float opacity )

my proposal: complete with some more parentheses
see: paintbuffer-gm-28.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/misc/paintbuffer.h 1038700 

Diff: http://reviewboard.kde.org/r/1927/diff


Testing
-------


Thanks,

Guy





More information about the kde-core-devel mailing list