Review Request: html_imageimpl.cpp:575: warning: suggest parentheses around & & within |

Guy Maurel guy-kde at maurel.de
Wed Oct 21 20:48:53 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1926/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/khtml/html/html_imageimpl.cpp:575: warning: suggest parentheses around && within ||
/.../kdelibs/khtml/html/html_imageimpl.cpp:580: warning: suggest parentheses around && within ||

at
QRegion HTMLAreaElementImpl::getRegion(int width_, int height_) const

my proposal: complete with some more parentheses
see: html_imageimpl-gm-27.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/html/html_imageimpl.cpp 1038700 

Diff: http://reviewboard.kde.org/r/1926/diff


Testing
-------


Thanks,

Guy





More information about the kde-core-devel mailing list