KFilePlacesModel/View question

[Chani]

On October 18, 2009 04:24:57 nf2 wrote:
> I'm wondering whether the device related code in KFilePlacesModel
> could be internalized a bit. So that the classes using it don't have
> to deal with devices directly (like kfilplacesview.cpp,
> systemmodel.cpp, placesengine.cpp, placesrunner.cpp). That way we
> could more easily plug a different model, for instance when running
> KDE apps outside KDE.
> 
> My question is about the code at line 152 in kfileplacesview.cpp:
> 
> if (((device.is<Solid::StorageAccess>() &&
> device.as<Solid::StorageAccess>()->isAccessible()) ||
>              (device.parent().is<Solid::StorageAccess>() &&
> device.parent().as<Solid::StorageAccess>()->isAccessible())) &&
>             ((device.is<Solid::StorageDrive>() &&
> device.as<Solid::StorageDrive>()->isRemovable()) ||
>              (device.parent().is<Solid::StorageDrive>() &&
> device.parent().as<Solid::StorageDrive>()->isRemovable())) &&
>             ((device.is<Solid::StorageDrive>() &&
> device.as<Solid::StorageDrive>()->driveType() !=
> Solid::StorageDrive::CdromDrive) ||
>              (device.parent().is<Solid::StorageDrive>() &&
> device.parent().as<Solid::StorageDrive>()->driveType() !=
> Solid::StorageDrive::CdromDrive))) {
>             isRemovableDevice = true;
>         }
> 
> It hardly ever sets isRemovableDevice = true (which would show the
> capacity bar), or perhaps i just don't have devices where it would.
> 
> Regards,
> Norbert
> 

that is one hell of an ugly line... but... you don't have a usb drive? :)

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091018/455f33c4/attachment.sig>