Fwd: Moved runner "Amarok" to kdereview

Jan Gerrit Marker jangmarker at googlemail.com
Sun Oct 18 18:32:47 BST 2009

Am Sonntag 18 Oktober 2009 16:30:59 schrieb Albert Astals Cid:
> I see
>   amarokrunner_config.cpp:77: warning: taking address of temporary
> that should be fixed as those warnings are pretty serious
Novice question: why are they serious?
I fixed both.
> Also a & is missing in
> foreach(const QString queryItem, queryItems) {
> foreach(const QVariantMap map, reply.value()) {
That is fixed, too (krazy complained about them, too ;)).
> And you are missing a Messages.sh file
Fixed, too (took the one of the Kill runner and adjusted it).

Thanks a lot :)
Jan Gerrit Marker (jangmarker)

More information about the kde-core-devel mailing list