Review Request: imageplane.cpp:87: warning: comparison between signed and unsigned integer expressions

[Maksim Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1863/#review2692
-----------------------------------------------------------

Ship it!


OK..

- Maksim


On 2009-10-16 17:42:15, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1863/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 17:42:15)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> khtml/imload/imageplane.cpp:87: warning: comparison between signed and unsigned integer expressions
> 
> at
> void ImagePlane::updatePixmap(PixmapTile* tile, const QImage& image, ...
> 
> as image.height() ist declared as "int", one must change the declaration of
> last (line 56) to "int"
> see: imageplane-gm-12.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/imload/imageplane.cpp 1033934 
> 
> Diff: http://reviewboard.kde.org/r/1863/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>