Review Request: imageplane.cpp:87: warning: comparison between signed and unsigned integer expressions

Guy Maurel guy-kde at maurel.de
Fri Oct 16 18:42:16 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1863/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
khtml/imload/imageplane.cpp:87: warning: comparison between signed and unsigned integer expressions

at
void ImagePlane::updatePixmap(PixmapTile* tile, const QImage& image, ...

as image.height() ist declared as "int", one must change the declaration of
last (line 56) to "int"
see: imageplane-gm-12.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/imload/imageplane.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1863/diff


Testing
-------


Thanks,

Guy





More information about the kde-core-devel mailing list