Review Request: dom_element.cpp:401: warning: comparison between signed and unsigned integer expressions

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1854/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdelibs/khtml/dom/dom_element.cpp:401: warning: comparison between signed and unsigned integer expressions

at
bool Element::khtmlMalformedQualifiedName(const DOMString &name)

There are two funtions of the same class which returns different types:
"int" and "unsigned int".

Also the parameters and many other functions have a mix.
One can also find "unsigned" and "uint".
Part of the problem is coming from "dom_stringimpl".

I propose to make a review and only use the "uint" type where possible.

The attached file ist not the best solution, it suppress only the warning.
see: dom_element-gm-10.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/dom/dom_element.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1854/diff


Testing
-------


Thanks,

Guy