Review Request: image.cpp:293: warning: comparison between signed and unsigned integer expressions

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1855/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
khtml/imload/image.cpp:293: warning: comparison between signed and unsigned integer expressions
khtml/imload/image.cpp:440: warning: comparison between signed and unsigned integer expressions
khtml/imload/image.cpp:442: warning: comparison between signed and unsigned integer expressions

at
void Image::notifyQImage(uchar version, const QImage *image)
and
void Image::refSize(QSize size)

The variables "width" and "height" are not proper declared.
I propose "unsigned int".
see: image-gm-11.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/imload/image.h 1033934 
  /trunk/KDE/kdelibs/khtml/imload/image.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1855/diff


Testing
-------


Thanks,

Guy