Review Request: function.cpp: 290: comparison between signed and unsigned integer expressions

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1828/
-----------------------------------------------------------

(Updated 2009-10-12 17:51:52.802830)


Review request for kdelibs.


Changes
-------

just change the signature and adjust the caller


Summary
-------

The kdelibs-Dashboard reports:
/.../kdelibs/kjs/function.cpp:290: warning: comparison between signed and unsigned integer expressions

at the line
Identifier FunctionImp::getParameterName(int index)

my proposal ist to introduce a local variable, make a proper definition of pos
see the attachted patch.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kjs/function.cpp 1033934 
  /trunk/KDE/kdelibs/kjs/scriptfunction.h 1033934 

Diff: http://reviewboard.kde.org/r/1828/diff


Testing
-------

at home


Thanks,

Guy