Review Request: Just displace the frame with the frameborder size when there is frameborder

Maksim Orlovich maksim.orlovich at kdemail.net
Mon Oct 12 16:14:43 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1818/#review2613
-----------------------------------------------------------


The layout code will also need to be changed to not reserve space for the border.
It may be easier to change the behavior of border() or add an effectiveBorder() 
and use that. (You can test with JS to determine how border() should behave, 
I think; though that's not too important).

- Maksim


On 2009-10-10 10:30:22, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1818/
> -----------------------------------------------------------
> 
> (Updated 2009-10-10 10:30:22)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Avoid the displacement of the frames when there is no frameborder.
> Posibly also fixes bug 138872
> 
> 
> This addresses bug 32563.
>     https://bugs.kde.org/show_bug.cgi?id=32563
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/rendering/render_frames.cpp 1032385 
> 
> Diff: http://reviewboard.kde.org/r/1818/diff
> 
> 
> Testing
> -------
> 
> http://www.grundleborg.com/kde/bugsquad/testcases/32563/
> The sites from bug 138872
> Another sites with frames
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list