Review Request: Just displace the frame with the frameborder size when there is frameborder

Jaime Torres jtamate at gmail.com
Sat Oct 10 20:29:44 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1818/#review2601
-----------------------------------------------------------


It is not valid, as in the testcase, the gray area is now a white area at the bottom (I did not notice it before :-( )

- Jaime


On 2009-10-10 10:30:22, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1818/
> -----------------------------------------------------------
> 
> (Updated 2009-10-10 10:30:22)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Avoid the displacement of the frames when there is no frameborder.
> Posibly also fixes bug 138872
> 
> 
> This addresses bug 32563.
>     https://bugs.kde.org/show_bug.cgi?id=32563
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/rendering/render_frames.cpp 1032385 
> 
> Diff: http://reviewboard.kde.org/r/1818/diff
> 
> 
> Testing
> -------
> 
> http://www.grundleborg.com/kde/bugsquad/testcases/32563/
> The sites from bug 138872
> Another sites with frames
> 
> 
> Thanks,
> 
> Jaime
> 
>





More information about the kde-core-devel mailing list