Review Request: Update KTabBar and KTabWidget to use the Qt>=4.5 "setSelectionBehaviorOnRemove" functions (QTabBar)

[Alex Merry]

I would mark it as KDE_DEPRECATED and add a documentation comment saying
/** @deprecated  This method has no effect and should not be called */

It should never have been protected by the looks of things (it should have 
been private instead), but you're right, there's no sensible alternative 
action to take.  I doubt anyone has actually ever used it anyway.

Incidentally, it seems a poor choice for a (protected) slot name, since 
QTabWidget has a signal of the same name...

Alex



On Sunday 11 October 2009 23:37:30 Darío Andrés wrote:
> > On 2009-10-11 22:28:11, Alex Merry wrote:
> > > The defunct slot should be tagged with KDE_DEPRECATED, and marked as
> > > @deprecated in the documentation (with an explanation of what should be
> > > used instead).
> 
> The problem is that there is no "X should be used instead". It was a
>  protected method in KTabBar only used to implement this "select previous
>  tab" feature. It is not used anymore... Any KTabBar subclass could
>  reimplement it for other purpose. But now, this slot is purposeless. Also,
>  the method never had documentation. What should be done in this case?
>  Regards
> 
> 
> - Darío
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1823/#review2609
> -----------------------------------------------------------
> 
> On 2009-10-11 16:18:27, Darío Andrés wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1823/
> > -----------------------------------------------------------
> >
> > (Updated 2009-10-11 16:18:27)
> >
> >
> > Review request for kdelibs.
> >
> >
> > Summary
> > -------
> >
> > This patches removes the duplicated function of "KTabWidget" about
> > selecting the previous tab on deletion (this feature was also conflicting
> > with QTabWidget/QTabBar if the "selectionBehaviorOnRemove" was set to
> > "SelectPreviousTab") It also forces "KTabBar" to use
> > "(set)selectionBehaviorOnRemove"(from Qt) on its function
> > "setTabCloseActivatePrevious" Qt docs says that the default value is
> > "SelectRightTab"; however I don't know if RTL users agree with this.... I
> > also removed a non virtual slot from KTabWidget as it was not used
> > anymore (this should be compatible.. am I wrong?)
> >
> > - Should the APIDOX be modified/updated ?
> >
> >
> > This addresses bugs 181124 and 207747.
> >     https://bugs.kde.org/show_bug.cgi?id=181124
> >     https://bugs.kde.org/show_bug.cgi?id=207747
> >
> >
> > Diffs
> > -----
> >
> >  
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cp
> >p 1033579
> > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/ktabwidget
> >.cpp 1033579
> >
> > Diff: http://reviewboard.kde.org/r/1823/diff
> >
> >
> > Testing
> > -------
> >
> > I tested this in Konqueror and it worked properly
> > https://bugs.kde.org/show_bug.cgi?id=181124 explains more testcase
> > situations (investigation before the patch)
> >
> >
> > Thanks,
> >
> > Darío
> 

-- 
Why have I got six monitors?  Because I haven't got room for eight.
  -- Terry Pratchett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091012/e2e8fa7c/attachment.sig>