Review Request: Add versioning check for thumbnailers.

Jacopo De Simoi wilderkde at gmail.com
Mon Nov 30 22:22:40 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/
-----------------------------------------------------------

(Updated 2009-11-30 22:22:39.977306)


Review request for kdelibs, Peter Penz, David Nolden, and David Faure.


Changes
-------

Add documentation in thumbcreator.h


Summary
-------

Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail. 

This fixes caching bugs with the improved jpeg thumbnailer.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1056802 
  trunk/KDE/kdelibs/kio/kio/thumbcreator.h 1056802 

Diff: http://reviewboard.kde.org/r/2282/diff


Testing
-------


Thanks,

Jacopo





More information about the kde-core-devel mailing list