Review Request: Add versioning check for thumbnailers.
David Faure
faure at kde.org
Mon Nov 30 11:54:53 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3341
-----------------------------------------------------------
The code looks ok now, but the overall mechanism should be documented somewhere.
- David
On 2009-11-27 19:01:11, Jacopo De Simoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
>
> (Updated 2009-11-27 19:01:11)
>
>
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
>
>
> Summary
> -------
>
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail.
>
> This fixes caching bugs with the improved jpeg thumbnailer.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240
>
> Diff: http://reviewboard.kde.org/r/2282/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jacopo
>
>
More information about the kde-core-devel
mailing list