polkit-kde also in kdereview

[Dario Freddi]

On Friday 27 November 2009 18:19:56 Albert Astals Cid wrote:
> A Dijous, 26 de novembre de 2009, Radek Novacek va escriure:
> > Hi,
> >
> > I've already send an email to this list early this week about moving
> >  polkit- qt-1 to the kdereview. I also moved the Authentication agent to
> >  the kdereview. It was called PolicyKit-kde, but we decide to rename it
> > to polkit-kde to be more consistent with upstream polkit and polkit-gnome
> > naming.
> >
> > Radek Novacek
> 
> foreach(QString key, details->getKeys()) {
> should be
> foreach(const QString &key, details->getKeys()) {

fixed

> 
> keyLabel->setText(key + ":");
> should be
> keyLabel->setText(i18nc("some context about what %1 is", "%1:", key);

Uhm, this one is quite hard: key is a value returned from PolicyKit we don't 
know anything about: how should we handle such a case?

Also, better note that this thing is in the form of

Some key: Some value

So I'm considering about moving it to a form dialog and actually remove the 
semicolon. I don't remember the policy for these things, any hints on how this 
should be handled?

> 
> Albert
> 

-- 
-------------------

Dario Freddi
KDE Developer
GPG Key Signature: 511A9A3B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091127/4c6c6031/attachment.sig>