Review Request: Add versioning check for thumbnailers.

Jacopo De Simoi wilderkde at gmail.com
Thu Nov 26 22:09:00 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/
-----------------------------------------------------------

(Updated 2009-11-26 22:08:59.947907)


Review request for kdelibs, Peter Penz, David Nolden, and David Faure.


Changes
-------

Correctly check for version numbers; handles the X.y.z case only; it should be good enough for thumbnailers (I don't expect to have more complicated versioning for them)


Summary
-------

Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail. 

This fixes caching bugs with the improved jpeg thumbnailer.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240 

Diff: http://reviewboard.kde.org/r/2282/diff


Testing
-------


Thanks,

Jacopo





More information about the kde-core-devel mailing list