Review Request: Add versioning check for thumbnailers.

[Michael Pyne]

> On 2009-11-25 19:35:42, Christoph Feck wrote:
> > trunk/KDE/kdelibs/kio/kio/previewjob.cpp, line 433
> > <http://reviewboard.kde.org/r/2282/diff/1/?file=15105#file15105line433>
> >
> >     Versions are no floating point numbers, e.g. version 1.30 is "better" than 1.5.
> 
> Peter Penz wrote:
>     I agree to Christophs comment. But in general I'd like to raise the question, whether it makes sense to check for v1 < v2? Wouldn't it be correct to just check for equality? I mean: as soon as the thumbnailer generator version does not match to the version of the thumbnails, the thumbnails must be recreated IMO. There is no need for providing some kind of backward compatibility between thumbnailer versions. Do I miss something here? By this the code would get a lot more straight forward...

One (admittedly rare) situation I could think of would be if and when we switch to KDE 5, it may be that KDE 4 Dolphin is being run alongside with KDE 5 Dolphin (let's say for testing), and if they both have different versions and both use a != check, then it's possible they'd both "fight" over the thumbnail (i.e. one generates it, the other re-generates, etc.)

We could simply compare major version numbers only perhaps (not sure how easy that is to do in this code at a glance).


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3277
-----------------------------------------------------------


On 2009-11-25 19:17:00, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
> 
> (Updated 2009-11-25 19:17:00)
> 
> 
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
> 
> 
> Summary
> -------
> 
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is defined and if so, checks that the software field in the existing thumbnail matches before using the cached thumbnail. 
> 
> This fixes caching bugs with the improved jpeg thumbnailer.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240 
> 
> Diff: http://reviewboard.kde.org/r/2282/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>