Review Request: Support QImage::Format_ARGB8565_Premultiplied in KIconEffect::colorize

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2273/#review3254
-----------------------------------------------------------

Ship it!


I do not really understand why "the image" suddenly is only 16 bit color, but it does not hurt to support those image formats, too. And probably should be backported.

What about the other KIconEffect methods? Or QImageBlitz?

- Christoph


On 2009-11-24 12:09:18, Christoph Bartoschek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2273/
> -----------------------------------------------------------
> 
> (Updated 2009-11-24 12:09:18)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> I have a thin client where kdevelop crashes in kiconeffect.cpp:386 because it writes way behind allocated memory. The reason is that the image is of format QImage::Format_ARGB8565_Premultiplied but kiconeffect expects 32bit values here and not 24 bit. Therefore the data vector is only 3/4 of the expected size and colorize() starts to write after allocated memory finally resulting in the crash.
> 
> The fix converts everything that is not 32bit to a supported format.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/icons/kiconeffect.cpp 1051650 
> 
> Diff: http://reviewboard.kde.org/r/2273/diff
> 
> 
> Testing
> -------
> 
> After patching kiconeffect.cpp kdevelop no longer crashes on the client.
> 
> 
> Thanks,
> 
> Christoph
> 
>