Review Request: Support QImage::Format_ARGB8565_Premultiplied in KIconEffect::colorize

[Christoph Bartoschek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2273/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

I have a thin client where kdevelop crashes in kiconeffect.cpp:386 because it writes way behind allocated memory. The reason is that the image is of format QImage::Format_ARGB8565_Premultiplied but kiconeffect expects 32bit values here and not 24 bit. Therefore the data vector is only 3/4 of the expected size and colorize() starts to write after allocated memory finally resulting in the crash.

The fix converts everything that is not 32bit to a supported format.


Diffs
-----

  trunk/KDE/kdelibs/kdeui/icons/kiconeffect.cpp 1051650 

Diff: http://reviewboard.kde.org/r/2273/diff


Testing
-------

After patching kiconeffect.cpp kdevelop no longer crashes on the client.


Thanks,

Christoph