Review Request: Watch over interface changes in Solid::PowerManagement
Kevin Ottens
ervin at kde.org
Wed Nov 18 06:53:36 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2196/#review3153
-----------------------------------------------------------
Wouldn't it work and be much simpler by using QDBusAbstractInterface::isValid() instead?
IIRC it's supposed to be updated on name onwer change as well, so it sounds like you're reinventing the wheel here.
- Kevin
On 2009-11-17 20:47:06, Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2196/
> -----------------------------------------------------------
>
> (Updated 2009-11-17 20:47:06)
>
>
> Review request for kdelibs and Kevin Ottens.
>
>
> Summary
> -------
>
> At the moment Solid::PowerManagement does not watch over interface validity, which is probably the cause for the bug attached. This patch should fix that.
>
> P.S.: I did not use the 4.6 goodness (QWeakPointer and QDBusServiceWatcher) as I intend to backport this. Done that I'll use them in trunk.
>
>
> This addresses bug 214921.
> https://bugs.kde.org/show_bug.cgi?id=214921
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1050644
> /trunk/KDE/kdelibs/solid/solid/powermanagement_p.h 1050644
>
> Diff: http://reviewboard.kde.org/r/2196/diff
>
>
> Testing
> -------
>
> Compiles and works
>
>
> Thanks,
>
> Dario
>
>
More information about the kde-core-devel
mailing list