Review Request: Watch over interface changes in Solid::PowerManagement

Dario Freddi drf54321 at gmail.com
Tue Nov 17 20:47:06 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2196/
-----------------------------------------------------------

Review request for kdelibs and Kevin Ottens.


Summary
-------

At the moment Solid::PowerManagement does not watch over interface validity, which is probably the cause for the bug attached. This patch should fix that.

P.S.: I did not use the 4.6 goodness (QWeakPointer and QDBusServiceWatcher) as I intend to backport this. Done that I'll use them in trunk.


This addresses bug 214921.
    https://bugs.kde.org/show_bug.cgi?id=214921


Diffs
-----

  /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1050644 
  /trunk/KDE/kdelibs/solid/solid/powermanagement_p.h 1050644 

Diff: http://reviewboard.kde.org/r/2196/diff


Testing
-------

Compiles and works


Thanks,

Dario





More information about the kde-core-devel mailing list