Review Request: [KIO::AccessManager] Avoid propagating duplicate redirection notifications...

[adawit at kde.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2204/
-----------------------------------------------------------

(Updated 2009-11-18 00:49:02.434296)


Review request for kdelibs.


Summary (updated)
-------

The internal QNetworkReply implementation of KIO::AccessManager connects to both 'redirection' and 'permanentRedirection' signals from KIO::Job. The HTTP ioslave always emits the redirection signal regardless of the redirection type (301/302) ; so connecting to permanentRedirection in this case is actually redundant and wrong. As such this patch eliminates the connection to the permanentRedirection signal...


Diffs
-----

  trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h 1050732 
  trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1050732 

Diff: http://reviewboard.kde.org/r/2204/diff


Testing
-------


Thanks,

adawit