Review Request: [KIO::AccessManager] Avoid propagating duplicate redirection notifications...
adawit at kde.org
adawit at kde.org
Wed Nov 18 00:43:53 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2204/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
The internal QNetworkReply implementation of KIO::AccessManager connects to both 'redirection' and 'permanentRedirection' signal of KIO::Job. The HTTP ioslave always emits the the KIO::Job::redirection signal regardless of type of redirection so connecting to permanentRedirection is actually redundant and wrong. This patch eliminates the connection to the permanentRedirection...
Diffs
-----
trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h 1050732
trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1050732
Diff: http://reviewboard.kde.org/r/2204/diff
Testing
-------
Thanks,
adawit
More information about the kde-core-devel
mailing list