Review Request: Move suggestions menu for misspelled word on top.

[Harsh J]

> On 2009-11-10 21:12:54, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp, lines 632-634
> > <http://reviewboard.kde.org/r/2097/diff/2/?file=14277#file14277line632>
> >
> >     to prevent it from becoming TOO large, perhaps a threshold value could be used such that the first N (10?) entries are shown in the top level of the menu and any more than that are shown in a "More Sugestions >" sub menu?
> >     
> >     this assumes that the suggestions arrive in a best-suggestion sort order.

Sonnet's default max is 10, so there should be no need for creating a submenu, yes?

The prototype for the call "highlighter.suggestionsForWord(selectedWord)" is:

    QStringList Sonnet::Highlighter::suggestionsForWord( const QString& word, int max = 10 )


- Harsh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2097/#review3003
-----------------------------------------------------------


On 2009-11-10 09:04:30, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2097/
> -----------------------------------------------------------
> 
> (Updated 2009-11-10 09:04:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Minor fix for the Bug 194979.
> 
> Bug-report requests that "Suggestions" in the context menu of spell-checker for a word, be moved to top instead of last.
> 
> Re-ordered the menu/action-adding code in KTextEdit to make the spelling "suggestions" appear first.
> 
> (Diff 1 keeps them in a popup, diff 2 moves them to top level - as in screenshots)
> 
> 
> This addresses bug 194979.
>     https://bugs.kde.org/show_bug.cgi?id=194979
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp 1046992 
> 
> Diff: http://reviewboard.kde.org/r/2097/diff
> 
> 
> Testing
> -------
> 
> Recompiled kdelibs and the superficial change appears fine.
> 
> 
> Screenshots
> -----------
> 
> Moved to top entry - suggestions
>   http://reviewboard.kde.org/r/2097/s/256/
> Moved to top level - suggestions
>   http://reviewboard.kde.org/r/2097/s/257/
> 
> 
> Thanks,
> 
> Harsh
> 
>