Review Request: Move suggestions menu for misspelled word on top.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2097/#review3003
-----------------------------------------------------------


this is indeed my biggest UI gripe with the current system as well and would like to see this action, which is almost certainly the most common reason for right clicking it, should be on top. i do have one comment below, however, about how to deal with the "too long a list" issue. once that's resolved, i think this should go in.


/trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp
<http://reviewboard.kde.org/r/2097/#comment2465>

    to prevent it from becoming TOO large, perhaps a threshold value could be used such that the first N (10?) entries are shown in the top level of the menu and any more than that are shown in a "More Sugestions >" sub menu?
    
    this assumes that the suggestions arrive in a best-suggestion sort order.


- Aaron


On 2009-11-10 09:04:30, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2097/
> -----------------------------------------------------------
> 
> (Updated 2009-11-10 09:04:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Minor fix for the Bug 194979.
> 
> Bug-report requests that "Suggestions" in the context menu of spell-checker for a word, be moved to top instead of last.
> 
> Re-ordered the menu/action-adding code in KTextEdit to make the spelling "suggestions" appear first.
> 
> (Diff 1 keeps them in a popup, diff 2 moves them to top level - as in screenshots)
> 
> 
> This addresses bug 194979.
>     https://bugs.kde.org/show_bug.cgi?id=194979
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/ktextedit.cpp 1046992 
> 
> Diff: http://reviewboard.kde.org/r/2097/diff
> 
> 
> Testing
> -------
> 
> Recompiled kdelibs and the superficial change appears fine.
> 
> 
> Screenshots
> -----------
> 
> Moved to top entry - suggestions
>   http://reviewboard.kde.org/r/2097/s/256/
> Moved to top level - suggestions
>   http://reviewboard.kde.org/r/2097/s/257/
> 
> 
> Thanks,
> 
> Harsh
> 
>