Qt KDE integration in kdereview.

[Olivier Goffart]

Le Wednesday 04 November 2009, Kevin Krammer a écrit :
> This cmake parameter makes the documentation wrong or at least not precise
> enough, which is really a pity.
> Variables that can be unset or empty should have specified defaults so
>  third parties implementing their own code can rely on that.
> 
> Has this always been overridable this way or is this a recent (KDE4)
>  addition?

I think it is new since KDE4 but i might be wrong.

> 
> > Besides, the end user can just as well toggle that switch as the packager
> >  if they build from source (and that's not the entire point of Olivier's
> >  patch anyways).
> 
> True. Lettings KDE handle these things is definitely better.
> Will avoid problems like the current heuristics in Qt which mistakenly
>  prefer .kde4 over .kde instead of the other way around (preferring
>  canonical default over one potential override).

The thing is: in practice, many distribution had .kde4 for kde4 and .kde for 
kde3 applications.
When we detect we are running in a kde4 desktop (again heuristics), we prefer 
.kde4 if it exists.

Now, we had the case of people that had a .kde4 in their /home because they 
tested development version at some point, and now use the distro package that 
uses .kde, and Qt get it wrong.


As  David suggested, there is the `kde4-config --localprefix`,  but this would 
have slow down every application startup just of that.  (One can argue that 
loading a plugin also slows down the startup, but it should still be much 
faster, and provides more stuff)

-- 
Olivier