Qt KDE integration in kdereview.

[Kevin Krammer]

On Wednesday, 2009-11-04, Michael Pyne wrote:
> On Tuesday 03 November 2009 17:10:19 Kevin Krammer wrote:
> > On Tuesday, 2009-11-03, Olivier Goffart wrote:
> > > Le Tuesday 03 November 2009, Kevin Krammer a écrit :
> > > > On Tuesday, 2009-11-03, Olivier Goffart wrote:
> > > > > Qt tries already to make KDE (and GNOME) as much as it can. For
> > > > > instance, we try to guess the KDE style and the
> > > > > KDE palette from the KDE config files.   This however not 100%
> > > > > reliable: For instance, we do not know the location of KDEHOME
> > > > > (when $KDEHOME is not set). Is it ~/.kde or ~/.kde4 or other? We
> > > > > use QSettings to parse the KDE config file (which does not
> > > > > understand every KDE tricks)
> > > >
> > > > KDEHOME is easy: $HOME/.kde is not set
> > > > http://techbase.kde.org/KDE_System_Administration/Environment_Variabl
> > > >es #K DE HOME
> > >
> > > No.  Some distribs change the default to .kde4 (there is a cmake flag
> > > to change it, and it can be set to anything)
> >
> > You mean they change the default but forget to apply the same change to
> > Qt?
> 
> You act like you're surprised. ;)

Well, actually I am.
I didn't know about this cmake parameter so I thought it was one of those 
unfortunate but necessary downstream modifications.
In which case they obviously would have to modify every other occurance of the 
default as well.

This cmake parameter makes the documentation wrong or at least not precise 
enough, which is really a pity.
Variables that can be unset or empty should have specified defaults so third 
parties implementing their own code can rely on that.

Has this always been overridable this way or is this a recent (KDE4) addition?

> Besides, the end user can just as well toggle that switch as the packager
>  if they build from source (and that's not the entire point of Olivier's
>  patch anyways).

True. Lettings KDE handle these things is definitely better.
Will avoid problems like the current heuristics in Qt which mistakenly prefer 
.kde4 over .kde instead of the other way around (preferring canonical default 
over one potential override).

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091104/f11ec631/attachment.sig>