Review Request: improved, Solid-based network error handling

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1933/#review2918
-----------------------------------------------------------


I like the idea, but obviously this needs to be tested.

Of course this can never be 100% correct in its analysis. Your network interfaces could be up and your router could be offline, or your ISP messing up routing, etc. ;) So "incorrectly typed" is really just one possibility among many ;)


trunk/KDE/kdelibs/kio/kio/global.cpp
<http://reviewboard.kde.org/r/1933/#comment2321>

    Please use a switch() to avoid calling Solid::Networking::Status() twice.


- David


On 2009-10-22 15:18:41, Marcus Harrison wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1933/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 15:18:41)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Adds Solid integration into basic network error-handling. This implementation should be applied across all applications that use standard error-handling messages, but I think it might be more proper for Solid to be integrated at the individual back-ends (for example, automatically disconnecting from online services and sending a message to the application a la Kopete).
> 
> This is my first patch, so feedback is welcomed and appreciated.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/global.cpp 1031233 
> 
> Diff: http://reviewboard.kde.org/r/1933/diff
> 
> 
> Testing
> -------
> 
> The only testing I have been able to do is to see whether this compiles properly - which it does. I have not been able to build kdebase/any individual applications against it recently, which is what I plan to do.
> 
> 
> Thanks,
> 
> Marcus
> 
>