[PATCH] Added title parameter to KNotification::event

Olivier Goffart ogoffart at kde.org
Mon May 25 22:12:26 BST 2009


Le Mandag 25 mai 2009, Davide Bettio a écrit :
> Hi,
>
> On Sunday 24 May 2009 15:13:08 Olivier Goffart wrote:
> > But i think that you should better not use those StandardEvent, but
> > creates notifications specifics to the application (akonady in this
> > case?) That way it is possible to configure if the user want a
> > notification or not for some particular event.
>
> I don't think that creating an event file for every application that has
> got a notification makes any sense... Are we interested to configure
> "akonadi has been stopped" notification? I don't think so. (btw:
> akonaditray now is using KPassivePopup).

Then you do not want to use KNotification,  and KPassivePopup is fine.  The 
problem is that KPassivePopup is ugly compared to the plasma notification. We 
need maybe an API for popup without KNotify.

But regarding your patch i said that i rather not add more argument to the 
event function. But I'm fine if you add a constructor that takes a 
StandardEvent

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090525/5bcb468b/attachment.sig>


More information about the kde-core-devel mailing list