[PATCH] Added title parameter to KNotification::event

[Olivier Goffart]

Le Søndag 24 mai 2009, Olivier Goffart a écrit :
> Le Søndag 24 mai 2009, Davide Bettio a écrit :
> > Hi,
> >
> > I've added a title parameter to KNotification::event:
> > http://reviewboard.kde.org/r/745/diff/#index_header
>
> I do not think this is a good idea.
>
> KNotification::event is a convenience function.  If you want more advanced
> stuff to the notification, you should create a KNotification object.
>
>
> Having the event function with such a huge number of parameter makes the
> code that uses it less readable and more error prone (which parameter does
> what)

Ok, i just noticed this was to the function that takes a StandardEvent, and 
that it is not possible to do that without the convinience API.
Maybe then you need to add a KNotification constructor that takes a 
StandardEvent.

But i think that you should better not use those StandardEvent, but creates 
notifications specifics to the application (akonady in this case?) That way 
it is possible to configure if the user want a notification or not for some 
particular event.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090524/5505a524/attachment.sig>