[PATCH] Added title parameter to KNotification::event

Olivier Goffart ogoffart at kde.org
Sun May 24 13:57:05 BST 2009


Le Søndag 24 mai 2009, Davide Bettio a écrit :
> Hi,
>
> I've added a title parameter to KNotification::event:
> http://reviewboard.kde.org/r/745/diff/#index_header

I do not think this is a good idea.

KNotification::event is a convenience function.  If you want more advanced 
stuff to the notification, you should create a KNotification object.


Having the event function with such a huge number of parameter makes the code 
that uses it less readable and more error prone (which parameter does what)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090524/927d7cd8/attachment.sig>


More information about the kde-core-devel mailing list