Review Request: ktimezoned version for Windows

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/645/#review1018
-----------------------------------------------------------


ktimezonedbase.h:

Shouldn't KTimeZoneDBase be spelled KTimeZonedBase for consistency with KTimeZoned?

The comment for configChanged() should not mention "the registry" since the base class applies to Unix as well:

    /** D-Bus signal emitted when the time zone configuration has changed. */

Please include me as a copyright holder in ktimezonedbase.h, since most of the code comes from the original ktimezoned.h/cpp.


ktimezoned.h:

Shouldn't the signal configChanged() be removed, since it will be inherited from the base class now?

Why have the signals zonetabChanged() and zoneDefinitionChanged() been removed - they are still emitted in ktimezoned.cpp (and used in KSystemTimeZones). Does this still compile under Linux?

The D-Bus declaration
    Q_CLASSINFO("D-Bus Interface", "org.kde.KTimeZoned")
has been removed, but I can't see anything to replace it. Is this correct?


ktimezoned_win.{h,cpp}: I haven't examined these.

- David


On 2009-04-30 06:01:40, Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/645/
> -----------------------------------------------------------
> 
> (Updated 2009-04-30 06:01:40)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This implements a ktimezoned version for Windows, which watches the registry for changes to the system time zone and informs KDE land of those changes. It required some bits to be pulled into a shared base class.
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise4/kdebase-4.2-branch/runtime/ktimezoned/CMakeLists.txt 961598 
>   branches/kdepim/enterprise4/kdebase-4.2-branch/runtime/ktimezoned/ktimezoned.h 961598 
>   branches/kdepim/enterprise4/kdebase-4.2-branch/runtime/ktimezoned/ktimezoned.cpp 961598 
>   branches/kdepim/enterprise4/kdebase-4.2-branch/runtime/ktimezoned/ktimezoned_win.h PRE-CREATION 
>   branches/kdepim/enterprise4/kdebase-4.2-branch/runtime/ktimezoned/ktimezoned_win.cpp PRE-CREATION 
>   branches/kdepim/enterprise4/kdebase-4.2-branch/runtime/ktimezoned/ktimezonedbase.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till
> 
>