Review Request: Timezone backend for Windows

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/647/#review1017
-----------------------------------------------------------


It looks fine (I haven't examined the implementation in ktimezone_win.cpp - I'm sure you know what you're doing there), apart from ktimezone_win.h.

ktimezone_win.h needs apidox comments.

KSystemTimeZoneSourceWindows: needs a d-pointer.

KSystemTimeZoneWindows: its class declaration should read as follows to avoid erroneous krazy errors:

class KDECORE_EXPORT KSystemTimeZoneWindows : public KTimeZone  //krazy:exclude=dpointer (no d-pointer for KTimeZone derived classes)

It should also have the usual comment, to make it clear why it doesn't have a d-pointer, as follows:

    private:
        // d-pointer is in backend class.
        // This is a requirement for classes inherited from KTimeZone.



- David


On 2009-05-01 02:58:26, Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/647/
> -----------------------------------------------------------
> 
> (Updated 2009-05-01 02:58:26)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch implements a timezone backend for windows. We've incorporated the suggestions from the review of the first version of this patch, cleaned it up overall, etc.
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise4/kdelibs-4.2-branch/kdecore/CMakeLists.txt 961961 
>   branches/kdepim/enterprise4/kdelibs-4.2-branch/kdecore/date/ksystemtimezone.cpp 961961 
>   branches/kdepim/enterprise4/kdelibs-4.2-branch/kdecore/date/ktimezone.cpp 961961 
>   branches/kdepim/enterprise4/kdelibs-4.2-branch/kdecore/date/ktimezone_win.h PRE-CREATION 
>   branches/kdepim/enterprise4/kdelibs-4.2-branch/kdecore/date/ktimezone_win.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/647/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till
> 
>