[PATCH] Rename Dialog, added KSeparator between files.

Shaun Reich predator106 at gmail.com
Tue Mar 24 19:01:20 GMT 2009

On Tue, Mar 24, 2009 at 9:45 AM, Sebastian Kügler <sebas at kde.org> wrote:
> On Saturday 21 March 2009 18:09:39 Shaun Reich wrote:
>> This patch I made adds a KSeparator between the source and dest files
>> (if that's what it is called in this case).
>> This pops up (I think, for the most part), when you say... have 2
>> folders, one named "Folder 1" and the other "Folder 2", if you rename
>> "Folder 2" to "Folder 1", this dialog will pop up.
>> I think this makes it easier to read, as it nicely separates the two
>> different files, before it was just bajumbled together.
>> Here is a screenshot of what it looks like....
>> http://picasaweb.google.com/predator106/OtherRandomScreenies#53156884402657
>> I kind of like it, since it clearly separates it.
> I think adding a bit of whitespace would work just as well but look less
> visually cluttered.
> The information displayed should probably also be improved. What's really
> interesting is if the new file is bigger or smaller, newer or older, has all
> the files in the other folder, or a sub/superset, .... Right now, that's not
> very intuitive to find out, and the information shown is pretty "raw".
> The separator between those two looks very KDE3-ish, I don't really like it.
> --
> sebas
>  http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9

Ok, I will come up with some more stuff for it sometime.  I actually
wanted to have whitespace between what the separator touches, to make
it not so cramped up, but I could not figure out how to do this. It is
using a grid layout, so I figured... logically, leaving 1 row empty
(adding the next widget after this "empty row") would leave a blank
line. Not the case for some reason.... I -also- figured that I could
just drop a QWidget in there, but that didn't work either... I have no
idea what it is I am doing wrong with this.

 > The separator between those two looks very KDE3-ish, I don't really like it.

Does it? I don't like KDE3's look, but only tasted it for a little
while before diving into the irresistable 4.1. :)

In which case, I will come up with something better. I was afraid that
even if I did introduce more white space as a row(s), that the text
would still be difficult to quickly tell, that they are different

I completely agree with you, it should be made more clear on what is
going on, etc.

Riverenter Vestri,
Shaun Reich

More information about the kde-core-devel mailing list