[PATCH] Fix for PageUp/PageDown in KTextEdit

David Faure faure at kde.org
Thu Mar 26 00:10:50 GMT 2009


On Wednesday 25 March 2009, Michael Leupold wrote:
> Hi,
> 
> On hitting PageUp/-Down in KTextEdit it pages by moving the cursor line by 
> line. This mimicks QTextEdit's behaviour with one small difference: QTextEdit 
> calculates the new cursor position and then sets it at the end. KTextEdit sets 
> the cursor position repeatedly line by line. This emits one 
> cursorPositionChanged() signal per line and can make applications showing the 
> cursor position feel slower than need be (eg. the KMail composer window).
> 
> This patch copies QTextEdit's behaviour. I'm unsure if there could be 
> regressions due to this change in behaviour but if there are those 
> applications should be fixed rather than not committing this patch (as it's 
> pretty hard to block that signal when scrolling starts).

If this fixes the weird scrolling in the kmail composer window, I'm all for it ;)

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list