[PATCH] Permanent clear button for KLineEdit

Aaron J. Seigo aseigo at kde.org
Wed Mar 25 16:24:21 GMT 2009


On Wednesday 25 March 2009, Michael Leupold wrote:
> > is this really useful for kmail? are there are other use cases for this?
>
> If you remove the text from one of the extra address lines without clicking
> the clear button the clear button will fade and you have no means of
> removing the line any longer.

ah, got it now. but isn't the bug in the composer window that it should check 
for content when editing is complete and if there is nothing in it, remove the 
line? that way the user doesn't need to click the clear button at all if they 
don't want to.

the QLineEdit::editingFinished() signal is really handy in those cases.

> > if there are some real use cases out there, ok, but it would be nice to
>
> avoid
>
> > api complexity and UI inconsistency if it's just a "because we can"
> > thing.
>
> The patch was driven by the need to fix forementioned bug in KMail. Of
> course KMail could implement an extra button to remove the address line but
> I consider the current solution pretty intuitive. Adding such an extra
> button would have the disadvantages of taking up more space and leading to
> UI inconsistency as well (restricted to KMail though).

agreed on those points indeed :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090325/22e0ad06/attachment.sig>


More information about the kde-core-devel mailing list