[PATCH] BUG: 178658 Adding remote encoding support to Dolphin
rahman.duran at gmail.com
Tue Mar 24 22:22:00 GMT 2009
On Tue, Mar 24, 2009 at 11:52 PM, Thiago Macieira <thiago at kde.org> wrote:
> Patch looks good, but before you commit, can you fix your indentation
> problems? Please use the same indentation as the rest of Dolphin (Dolphin
> appears to be using 4-space indentation but your new file is doing 2-then-4
> and some braces are in weird positions).
Yes, I know, I will clean it. Its because the kremoteencodingplugin.cpp file
is abit out-dated doesn't fit KDE coding standarts :)
Wasn't there a way to share this code with Konqueror?
There isn't a way for Dolphin to share Konqueror code, But when I commit
this there will be a way for Konqueror to share Dolphin code ;-)
I will make DolphinPart to use DolphinRemoteEncoding So Konqueror will share
same code. Thus we can get rid off KRemoteEncodingPlugin in Konqueror.
How many apples fell on Newton's head before he took the hint!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-core-devel